fix(bb): avoid debug abort in acir components missing witness test - #24782
Closed
AztecBot wants to merge 1 commit into
Closed
fix(bb): avoid debug abort in acir components missing witness test#24782AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcirComponentsCheckTest.DetectsUnconstrainedWitnessesso it models an ACIR-vs-circuit mismatch without corruptingUltraCircuitBuilder::real_variable_index.UNCONSTRAINEDcoverage by checking an ACIR circuit that references a witness absent from the synthesized builder circuit.Root Cause
The nightly debug build failed in the canonical run AztecProtocol/aztec-packages#29632849696 while running
AcirComponentsCheckTest.DetectsUnconstrainedWitnesses. The test intentionally resizedbuilder.real_variable_indexto 9 entries, but the builder's trace still referenced witness index 10. In the debug preset,_GLIBCXX_DEBUGturns that invalid vector subscript into an abort beforeComponentsCheckercan report the expectedUNCONSTRAINEDerror.The initially linked mirror run AztecProtocol/aztec-claude#29632747051 failed earlier with
gzip: stdout: Broken pipebecause scheduled mirror CI lacks the Redis/SSH/AWS environment. The canonicalaztec-packagesworkflow has the real debug build failure above.Testing
clang-format-20 -i barretenberg/cpp/src/barretenberg/acir_components_check/components_check.test.cppgit diff --checkcmake --preset debug -DAVM_TRANSPILER_LIB= && cmake --build --preset debug --target acir_components_check_tests./build-debug/bin/acir_components_check_tests --gtest_filter=AcirComponentsCheckTest.DetectsUnconstrainedWitnesses./build-debug/bin/acir_components_check_testsCreated by claudebox · group:
slackbot